feat(TranslateDefaultParser): make interpolation functions protected to allow ineritance #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-don
changed the title
|
A more in-depth change for this. You now get even more flexibility :-) |
|
@CodeAndWeb Check please this comment 4562aef#r152860552 I think there is a small bug, and I don't see any test about that logic :) |
CodeAndWeb
added a commit
that referenced
this pull request
Feb 21, 2025
|
Fixed this. And also the not yet handled null. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed
privatetoprotectedto have an ability to extend this class and override just one method. In my case I need to override logic ininterpolateStringmethod to use''instead ofsubstringif value is not defined.