-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(store): add @ngxs/store/internal/testing #1034
Conversation
@splincode What does this provide to the user that could not just be done simply through |
#1007
describe('Zoo', () => {
let store: Store;
beforeEach(() => {
const describer = NgxsTestBed.configureTestingState(
[ ZooState ],
{ developmentMode: false },
[
FeatureModule,
NgxsStoragePluginModule.forRoot()
]
);
store = describer.store;
})
it('it toggles feed', (done) => {
// use store
});
}); |
I believe that the creation of a IMO, the feature introduced by this particular PR is more focused on testing the I propose the following:
|
PS. Down the line if we do end up creating our own |
@markwhitfeld One of the main problems, why I don’t want to do this in a lab project, is because it’s not convenient to test on our internal tests. Having translated internal tests for our development we will be able to work out the API ourselves. |
Ok, could we then make these test helpers internal to our tests for now then? |
Sub package |
Hi, see #1007 (comment) and #1007 (comment) |
@markwhitfeld ping |
# Conflicts: # packages/store/tests/state.spec.ts
@markwhitfeld I add this PR for internal testing and fixes |
@splincode sorry I didn't get back to you. I have had a very busy week. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
own ability to manage testing more convenient
Does this PR introduce a breaking change?