Make parser run idiomatic ruby #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the extract method pattern to pull out 2 new helper methods
2 new tests in parser to test the methods I extracted. The tests
were written against the original code before I made the
refactor.
* removal of _ prefix on local variables
* #run is now shorter and more expressive
* opt for reduce over each instead of declaring a local collection
and then 'stuffing' it on each iteration
* opt for an inline hash and declarations
|
I'm all for refactoring and learning how to do things the proper Ruby way so this sounds good. I am definitely interested in the blog posts / screencast idea though, I think that would be a great resource not only for people but me as well :) I have some functionality changes I'd like to get in and then I will revisit this refactoring issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the project!
I would like to do a bunch of refactoring and test cleanup to make this more idiomatic. What do you guys think?
I will likely be making blog posts about the changes and possibly screencasts. There is some very nice code here, it just isn't very 'ruby'