Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickable image DL #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clickable image DL #130

wants to merge 1 commit into from

Conversation

amaiaita
Copy link
Collaborator

@amaiaita amaiaita commented Jul 17, 2024

Description

What: make home image clickable on the DL hub

🧠Why?: navigation within the DL hub

👨‍💻How?: setting image areas in the image that link to the different areas

Checklist:

Have checked for the following:

  • The website still builds correctly, and you can view it using mkdocs serve.
  • There are no new "warnings" from mkdocs
  • Does your page follow the page template (or here in Markdown)? (need to make a new one specific to NHSE Data Science)
  • Spelling errors
  • Consistent capitalization
  • Consistent numbers
  • Material features incorrectly implemented: search for code blocks and markers (e.g. !!!).
  • Code snippets don't work
  • Images not working
  • Links not working

Where it was tested

  • Github Codespaces - 2-core, 4GB RAM, 32GB hard drive
  • devcontainer.json describes further settings

Copy link
Contributor

@GiuliaMantovani1 GiuliaMantovani1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the clickable areas are slightly off especially on the Quality Assurance Framework and MPS documentation. I think you created the area too much to the right and lower than where the circles are.
not major, but possibly could be adjusted?
Also, I noticed that this problem only occurs when you zoom in the page, while if you are zoomed out, it seems aligned. So if you fix this, check that it still works at different zoomed-in points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants