Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SprightBlazor project #1976

Closed
3 tasks done
m-akinc opened this issue Mar 28, 2024 · 0 comments · Fixed by #2083
Closed
3 tasks done

Create SprightBlazor project #1976

m-akinc opened this issue Mar 28, 2024 · 0 comments · Fixed by #2083
Assignees
@m-akinc
Labels
enhancement New feature or request

Comments

@m-akinc
Copy link
Contributor

m-akinc commented Mar 28, 2024 •
edited
Loading

🙋 Feature Request

😯 Problem to Solve

Part of setting up Spright.

💁 Proposed Solution
@m-akinc m-akinc added enhancement New feature or request triage New issue that needs to be reviewed labels Mar 28, 2024
@m-akinc m-akinc mentioned this issue Mar 28, 2024
Merged
1 task
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Apr 2, 2024
@m-akinc m-akinc moved this from Backlog to Defined/Ready to Pickup in Nimble Design System Priorities Apr 18, 2024
@m-akinc m-akinc moved this from Defined/Ready to Pickup to Current Iteration in Nimble Design System Priorities Apr 22, 2024
@m-akinc m-akinc moved this from Current Iteration to In progress in Nimble Design System Priorities Apr 24, 2024
@m-akinc m-akinc self-assigned this Apr 24, 2024
@m-akinc m-akinc mentioned this issue Apr 24, 2024
Merged
1 task
rajsite added a commit that referenced this issue May 1, 2024
@m-akinc @rajsite
Create SprightBlazor project (#2036)
ed21267 
# Pull Request

## 🤨 Rationale

Partially addresses #1976

## 👩‍💻 Implementation

Initially I had created a separate `spright-blazor` folder/package with
its own VS solution, but it seems more fitting to just add Spright
projects to the existing solution. This required creating separate
`package.json` files located in the project directories. The old
`package.json` in the solution directory was changed into a private
package, similar to our Angular workspace package.

I opted to leave the directory name as `packages/nimble-blazor`, but for
consistency we might want to change it to `blazor-workspace` (matching
the private package name). The same goes for the solution name.

## 🧪 Testing

- Spot tested `build`, `lint`, `format`, `pack`, and `test` commands
from root of Blazor workspace.
- Tested that the example builds and runs.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
@m-akinc m-akinc mentioned this issue May 2, 2024
Merged
1 task
rajsite added a commit that referenced this issue May 2, 2024
@m-akinc @rajsite
Rename Blazor workspace and solution (#2068)
358fef9 
# Pull Request

## 🤨 Rationale

Part of #1976

## 👩‍💻 Implementation

- Renamed directory from `packages/nimble-blazor` to
`packages/blazor-workspace`
- Renamed solution from `NimbleBlazor.sln` to `BlazorWorkspace.sln`
- Updated workspace name in `package.json`
- Updated paths in `CODEOWNERS`, `main.yml`, and a couple other files

## 🧪 Testing

PR build

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
This was referenced May 7, 2024
Merged
Merged
Merged
@rajsite rajsite mentioned this issue May 8, 2024
Closed
2 tasks
rajsite added a commit that referenced this issue May 8, 2024
@m-akinc @rajsite
Refactor common Blazor acceptance test code (#2074)
0195da9 
# Pull Request

## 🤨 Rationale

Part of #1976

## 👩‍💻 Implementation

I've created a new project in `blazor-workspace` to contain code shared
between the Nimble and Spright acceptance test projects. I ran into
issues with the page components not being found when running tests from
the VS Test Explorer. Through trial and error, I discovered that the
`Setup` instance needed to be created in the same assembly as the page
components for them to be discovered. Normally this is governed by the
`AppAssembly` property of the `Router` component (in `App.razor`), but
that is not used by the test runner.

## 🧪 Testing

Tests pass.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
rajsite added a commit that referenced this issue May 9, 2024
@m-akinc @jattasNI @rajsite
Update Blazor docs for Spright and workspace change (#2083)
43edba8 
# Pull Request

## 🤨 Rationale

Closes #1976

## 👩‍💻 Implementation

- Moved most of previous, workspace `README.md` into new
`NimbleBlazor/README.md` file. Some content remains in the workspace
`README.md`.
- Moved workspace `CONTRIBUTING.md` into `NimbleBlazor/`
- Created new `README.md` and `CONTRIBUTING.md` in `SprightBlazor/`
- Fixed link paths to Blazor documentation from other documentation

## 🧪 Testing

N/A

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Jesse Attas <[email protected]>
Co-authored-by: Milan Raj <[email protected]>
@m-akinc m-akinc moved this from In progress to Done in Nimble Design System Priorities May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-akinc m-akinc

Labels
enhancement New feature or request
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Blazor docs for Spright and workspace change ni/nimble
1 participant
@m-akinc