Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Required Inputs HLD #2395

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Create Required Inputs HLD #2395

merged 8 commits into from
Sep 30, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Sep 12, 2024

Pull Request

🀨 Rationale

HLD for #2100

πŸ‘©β€πŸ’» Implementation

Wrote HLD.

πŸ§ͺ Testing

N/A

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc
Copy link
Contributor Author

m-akinc commented Sep 12, 2024

@msmithNI do you mind buddying?

@m-akinc m-akinc requested a review from msmithNI September 12, 2024 21:47
@m-akinc m-akinc marked this pull request as ready for review September 13, 2024 22:57
specs/required-inputs/README.md Outdated Show resolved Hide resolved
specs/required-inputs/README.md Outdated Show resolved Hide resolved
specs/required-inputs/README.md Show resolved Hide resolved
specs/required-inputs/README.md Outdated Show resolved Hide resolved
specs/required-inputs/README.md Show resolved Hide resolved
specs/required-inputs/README.md Show resolved Hide resolved
specs/required-inputs/README.md Show resolved Hide resolved
specs/required-inputs/README.md Show resolved Hide resolved
@m-akinc m-akinc requested a review from jattasNI September 19, 2024 00:30
specs/required-inputs/README.md Show resolved Hide resolved
specs/required-inputs/README.md Outdated Show resolved Hide resolved
specs/required-inputs/README.md Outdated Show resolved Hide resolved
specs/required-inputs/README.md Outdated Show resolved Hide resolved
specs/required-inputs/README.md Show resolved Hide resolved
@m-akinc m-akinc enabled auto-merge (squash) September 30, 2024 19:36
@rajsite
Copy link
Member

rajsite commented Sep 30, 2024

fyi @m-akinc merging is blocked on menu story instability, see #1479 (comment)

@m-akinc m-akinc requested a review from fredvisser as a code owner September 30, 2024 21:40
@m-akinc m-akinc merged commit c6335f1 into main Sep 30, 2024
13 checks passed
@m-akinc m-akinc deleted the users/makinc/required-inputs-hld branch September 30, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants