Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Enums to CLAY_PACKED_ENUM #185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change Enums to CLAY_PACKED_ENUM #185

wants to merge 4 commits into from
+5 −5

Conversation

sayedMurtadha
Copy link

Closes #179

@nicbarker
Copy link
Owner

Thanks for getting the ball rolling on this, we will also have to update the types in the various bindings, Odin and web for examples 🙂

@sayedMurtadha
Copy link
Author

@nicbarker I have updated the pull request to include Odin bindings. I have found only one enum type that does not use EnumBackingType and rebuilt the clay lib in the odin directory using the shell script build-clay-lib.sh. Please let me know if I missed anything, thanks : )

@nicbarker
Copy link
Owner

Thanks for doing this! I will hopefully get to this today 🙂

@FintasticMan
Copy link
Contributor

Shouldn't it be considered private by using CLAY__PACKED_ENUM with 2 underscores rather than 1? Not related to the changes in this PR, just an observation on the existing code around this.

@nicbarker nicbarker force-pushed the main branch 2 times, most recently from 4fd677e to 338852b Compare January 14, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Use CLAY_PACKED_ENUM for all enum types
3 participants
@sayedMurtadha @nicbarker @FintasticMan