demumble swift symbols as well #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…looks like nobody ever tried building swift with gcc?? Builds fine and seems to work with clang locally. |
nico
force-pushed
the
swift
branch
2 times, most recently
from
b74807a to
522cce5
Compare
LLVM at 3a4c7cc56c07b2db Swift at a894dd277544b
Fixes:
third_party/swift/include/swift/Demangling/Demangler.h:228:11:
error: declaration of ‘swift::Demangle::NodeFactory::Slab* swift::Demangle::NodeFactory::Checkpoint::Slab’
changes meaning of ‘Slab’ [-fpermissive]
228 | Slab *Slab;
| ^~~~
third_party/swift/include/swift/Demangling/Demangler.h:47:10:
note: ‘Slab’ declared here as ‘struct swift::Demangle::NodeFactory::Slab’
47 | struct Slab {
| ^~~~
Cherry-picks swiftlang/swift#75682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32.
A bit of a mess since swift's demangler is much less hermetic than LLVM's.