Change arguments.callee to prevent exception being thrown when running in strict mode #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test. * Changed arguments.callee to function name 'Assertion' in lib/chai/assertion.js to add compatability for strict mode.
|
Can you give me an example on a scenario where the exception is thrown? And also which failing test are you referring to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! First off, thank you for your work. My team benefits from it every day.
This PR is based on my team's encounter with the error noted in this issue: chaijs#578
I believe this change should be a noop, but I await your feedback. I've tested locally, both running the test suite and integration within my project. Based on the nature of this change and existing tests, I don't think additional tests are needed. The constructor seems to have coverage that should break if this change carried ill effects.
The changes are:
Thank you for your consideration of this PR. Please let me know if I should take additional steps to meet your requirements for contribution. I looked for guidelines, but couldn't find any.