Fixed #3132 - Mark test scenarios passed/failed and send reason to Browserstack while using Cucumber as a test-runner #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityvi
changed the title
beatfactor
reviewed
Apr 5, 2022
beatfactor
reviewed
Apr 5, 2022
beatfactor
requested changes
May 1, 2022
|
|
||
| //send test-case result to cloud provider | ||
| const {result} = testCase; | ||
| if (this.client.transport && this.client.transport.usingBrowserstack && result) { |
There was a problem hiding this comment.
This is too specific. We need a default method on the base transport and then overwrite that in the browserstack transport.
beatfactor
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Afterhook and send to BrowserStack.transportfrom NightwatchcreateClient.Impacts