Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject command node promise on abortOnFailure. #4314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garg3133
Copy link
Member

If a command results in an error with abortOnFailure set to true, the node promise of the command inside the test case still gets resolved instead of getting rejected, while the queue is anyway cleared because of abortOnFailure.

This leads to a situation where if we chain some more commands after this command in the test case, the test would get stuck (because the queue is emptied) and hence will abort successfully. But, if the await is directly used on the command, that await will resolve and the test will continue normally since the following commands will be added to the queue after the queue is cleared.

The command promise inside the test case should instead be rejected so that the test case throws an error and thus aborting itself instead of continuing normally.

TODO: Find out which commands it affects.

Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant