-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numberSeparators.test fails on armhf #662
Comments
There is a similar, related test failure:
'0xCAFE_F00D' is hexadecimal for 3405705229, which is the same number as in the syntax issue above. The test is receiving this as a T_DNUMBER (i.e. type number 313) rather than as a T_LNUMBER (type 312) as defined in Tokens.php. |
I guess the PHP-Parser tests are not 32-bit compatible. I wonder if it's possible to test 32-bit on Travis... |
athos-ribeiro
added a commit
to athos-ribeiro/PHP-Parser
that referenced
this issue
Nov 12, 2022
* See GH nikic#662 for further reference.
nikic
added a commit
that referenced
this issue
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the Ubuntu CI, the new php-parser 4.4.0 fails on one of the newly added test cases, only on armhf, with this error:
I'm guessing this is checking range on long data types, maybe a signed/unsigned mismatch? For ARM, it looks like a signed long is 32 bits word-aligned, or -2,147,483,648 to 2,147,483,647, and guessing 3,405,705,229 is getting returned as 0 as it's out of range?
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/armhf/p/php-parser/20200501_165040_5a5c8@/log.gz
Downstream bug: https://bugs.launchpad.net/ubuntu/+source/php-parser/+bug/1878102
The text was updated successfully, but these errors were encountered: