Skip to content

Commit

Permalink
[NFC][YAML] Add IO::error() (llvm#123475)
Browse files Browse the repository at this point in the history
  • Loading branch information
vitalybuka authored Jan 23, 2025
1 parent 4bcdb26 commit 4f26edd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 3 additions & 1 deletion llvm/include/llvm/Support/YAMLTraits.h
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,7 @@ class IO {
virtual NodeKind getNodeKind() = 0;

virtual void setError(const Twine &) = 0;
virtual std::error_code error() = 0;
virtual void setAllowUnknownKeys(bool Allow);

template <typename T>
Expand Down Expand Up @@ -1448,7 +1449,7 @@ class Input : public IO {
~Input() override;

// Check if there was an syntax or semantic error during parsing.
std::error_code error();
std::error_code error() override;

private:
bool outputting() const override;
Expand Down Expand Up @@ -1631,6 +1632,7 @@ class Output : public IO {
void scalarTag(std::string &) override;
NodeKind getNodeKind() override;
void setError(const Twine &message) override;
std::error_code error() override;
bool canElideEmptySequence() override;

// These are only used by operator<<. They could be private
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/Support/YAMLTraits.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,8 @@ void Output::scalarTag(std::string &Tag) {
void Output::setError(const Twine &message) {
}

std::error_code Output::error() { return {}; }

bool Output::canElideEmptySequence() {
// Normally, with an optional key/value where the value is an empty sequence,
// the whole key/value can be not written. But, that produces wrong yaml
Expand Down

0 comments on commit 4f26edd

Please sign in to comment.