Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tab not totally compatible with Reno theme in 2.5.0 and dev #1

Open
netcarver opened this issue Sep 24, 2014 · 4 comments · May be fixed by #4
Open

Added tab not totally compatible with Reno theme in 2.5.0 and dev #1

netcarver opened this issue Sep 24, 2014 · 4 comments · May be fixed by #4

Comments

@netcarver
Copy link

There seems to be a slight incompatibility with the tabs in the new admin theme...

reno-theme-prob

The fields appear below the buttons.

@somatonic
Copy link

I found the way to get around this is by using form->prepend rather than append

@somatonic
Copy link

Note that prepend will still add the tab button at the end of the tab list. But in PW2.4 it will add it before the content tab. So there was definately some changes to how the tabs work in PW2.5. Good luck.

@somatonic
Copy link

This should get around version issue

if(ProcessWire::versionMinor <= 4) $form->append($tab);
if(ProcessWire::versionMinor >= 5) $form->prepend($tab);

Or maybe check for major version is necessary here too...
My fix in TemplateNotes somatonic/TemplateNotes@7a16e25

gmclelland added a commit to gmclelland/PageReferencesTab that referenced this issue Aug 30, 2017
This fixes niklaka#1 and part of niklaka#3
@gmclelland gmclelland linked a pull request Aug 30, 2017 that will close this issue
@gmclelland
Copy link

For those interested. I submitted a PR to fix this at #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants