turn off prefer-destructuring

nikolai-katkov · Jan 27, 2024 · 6b48c9c · 6b48c9c
1 parent 68a01c6
commit 6b48c9c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -192,7 +192,6 @@ rules:
     - never
   prefer-arrow-callback: error
   prefer-const: error
-  prefer-destructuring: error
   prefer-exponentiation-operator: error
   prefer-named-capture-group: error
   prefer-object-spread: error

diff --git a/src/config/rulesets/ruleset.eslint.ts b/src/config/rulesets/ruleset.eslint.ts
@@ -956,7 +956,7 @@ export const ruleset: Record<string, Rule> = {
     fixable: true,
   },
   'prefer-destructuring': {
-    enabled: true,
+    enabled: false, // does not work well with `let` and variables in the outer context
     fixable: true,
   },
   'prefer-numeric-literals': {

diff --git a/src/lib/context/settings.ts b/src/lib/context/settings.ts
@@ -69,7 +69,6 @@ export const getSettings = (projectDirectory: string): Settings => {
   if (process.env.DML_SEMI !== undefined) {
     semi = process.env.DML_SEMI === '1'
   } else if (typeof rcSettings.semi === 'boolean') {
-    // eslint-disable-next-line prefer-destructuring
     semi = rcSettings.semi
   } else {
     semi = false