fix #19266; allow reassign discriminant field #19565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Feb 25, 2022
| @@ -300,6 +300,7 @@ type | |||
| sfSingleUsedTemp # For temporaries that we know will only be used once | |||
| sfNoalias # 'noalias' annotation, means C's 'restrict' | |||
| sfEffectsDelayed # an 'effectsDelayed' parameter | |||
| sfUncheckedDiscriminant | |||
Araq
reviewed
Feb 25, 2022
| elif c.inUncheckedAssignSection > 0 and | ||
| a.kind in {nkDotExpr, nkCheckedFieldExpr} and | ||
| a[1].kind == nkSym: | ||
| a[1].sym.flags.incl sfUncheckedDiscriminant |
There was a problem hiding this comment.
So ... when the disc field is used once in an unchecked assign section it gets tainted for good?
Araq
reviewed
Feb 25, 2022
| let field = dotExpr[1].sym | ||
| let field = dotExpr[1].sym | ||
| if optTinyRtti notin p.config.globalOptions and | ||
| sfUncheckedDiscriminant notin field.flags: |
There was a problem hiding this comment.
This is not a property of the symbol! It's a property of the .cast construct!
Araq
reviewed
Feb 25, 2022
| {.cast(uncheckedAssign).}: | ||
|
|
||
| # inside the 'cast' section it is allowed to assign to the 't.kind' field directly: | ||
| t.kind = intLit |
There was a problem hiding this comment.
And any other assignments to t.kind will not be checked afterwards...
|
I agree. I will make a new PR today or tomorrow. |
|
Succeeded by #19567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19266
It unblocks #19510
ref nim-lang/RFCs#407