Converted to Preconditions.checkNotNull.

nimakarimipour · Jan 25, 2022 · 255bc60 · 255bc60
1 parent 750ff31
commit 255bc60
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java b/nullaway/src/main/java/com/uber/nullaway/ErrorBuilder.java
@@ -32,6 +32,7 @@
 import static com.uber.nullaway.NullAway.getTreesInstance;
 
 import com.google.common.base.Joiner;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
@@ -518,12 +519,9 @@ public void serializeFixSuggestion(VisitorState state, Symbol target, ErrorMessa
     FixLocation location = AbstractFixLocation.createFixLocationFromSymbol(target);
     SuggestedFixInfo suggestedFixInfo = buildFixMetadata(state.getPath(), errorMessage, location);
     Serializer serializer = serializationConfig.getSerializer();
-    if (serializer != null) {
-      serializer.serializeSuggestedFixInfo(suggestedFixInfo, serializationConfig.suggestEnclosing);
-    } else {
-      throw new IllegalStateException(
-          "Serializer shouldn't be null at this point, error in configuration setting!");
-    }
+    Preconditions.checkNotNull(
+        serializer, "Serializer shouldn't be null at this point, error in configuration setting!");
+    serializer.serializeSuggestedFixInfo(suggestedFixInfo, serializationConfig.suggestEnclosing);
   }
 
   /**
@@ -534,12 +532,9 @@ public void serializeFixSuggestion(VisitorState state, Symbol target, ErrorMessa
    */
   public void serializeReportingError(VisitorState state, ErrorMessage errorMessage) {
     Serializer serializer = config.getSerializationConfig().getSerializer();
-    if (serializer != null) {
-      serializer.serializeErrorInfo(new ErrorInfo(state.getPath(), errorMessage));
-    } else {
-      throw new IllegalStateException(
-          "Serializer shouldn't be null at this point, error in configuration setting!");
-    }
+    Preconditions.checkNotNull(
+        serializer, "Serializer shouldn't be null at this point, error in configuration setting!");
+    serializer.serializeErrorInfo(new ErrorInfo(state.getPath(), errorMessage));
   }
 
   /** Builds the {@link SuggestedFixInfo} instance based on the {@link ErrorMessage} type. */