Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#549] Refactor: data module packages #536

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

luongvo
Copy link
Member

@luongvo luongvo commented Oct 6, 2023

Closes #549

What happened 👀

  • Separate between local vs remote data sources.
  • Move all requests and responses models into remote/models package.

Insight 📝

We forgot to apply "Use the plural for packages with homogeneous contents" for the sample-compose from #520.

Proof Of Work 📹

The app works properly ✅

@luongvo luongvo self-assigned this Oct 6, 2023
@luongvo luongvo temporarily deployed to template-compose October 6, 2023 07:31 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

12 Warnings
⚠️ Uh oh! ApiServiceProvider.kt is under 95% coverage!
⚠️ Uh oh! AppDestination.kt is under 95% coverage!
⚠️ Uh oh! AppNavigation.kt is under 95% coverage!
⚠️ Uh oh! BaseSharedPreferences.kt is under 95% coverage!
⚠️ Uh oh! ConverterFactoryProvider.kt is under 95% coverage!
⚠️ Uh oh! EncryptedSharedPreferences.kt is under 95% coverage!
⚠️ Uh oh! HomeScreen.kt is under 95% coverage!
⚠️ Uh oh! ResponseMapping.kt is under 95% coverage!
⚠️ Uh oh! RetrofitProvider.kt is under 95% coverage!
⚠️ Uh oh! SharedPreferencesExt.kt is under 95% coverage!
⚠️ Uh oh! UiModel.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 63.04%

Coverage of Modified Files:

File Coverage
ApiServiceProvider.kt 0.00%
AppDestination.kt 83.87%
AppNavigation.kt 52.63%
AppPreferencesRepositoryImpl.kt 100.00%
BaseSharedPreferences.kt 0.00%
ConverterFactoryProvider.kt 0.00%
EncryptedSharedPreferences.kt 0.00%
Error.kt 100.00%
ErrorResponse.kt 100.00%
Exceptions.kt 100.00%
HomeScreen.kt 63.66%
HomeViewModel.kt 100.00%
Model.kt 100.00%
MoshiBuilderProvider.kt 100.00%
RepositoryImpl.kt 100.00%
Response.kt 100.00%
ResponseMapping.kt 90.85%
RetrofitProvider.kt 0.00%
SharedPreferencesExt.kt 0.00%
UiModel.kt 84.21%

Modified Files Not Found In Coverage Report:

.keep
.keep
.keep
.keep
.keep
.keep
ApiService.kt
ApiService.kt
AppPreferencesRepository.kt
AppPreferencesRepositoryImplTest.kt
GetModelsUseCase.kt
GetModelsUseCaseTest.kt
HomeScreenTest.kt
HomeViewModelTest.kt
IsFirstTimeLaunchPreferencesUseCase.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
Item.kt
ItemList.kt
MockUtil.kt
MockUtil.kt
MockUtil.kt
MockUtil.kt
MoshiModule.kt
MoshiModule.kt
PreferencesModule.kt
Repository.kt
RepositoryModule.kt
RepositoryModule.kt
RepositoryTest.kt
RepositoryTest.kt
ResponseMappingTest.kt
ResponseMappingTest.kt
RetrofitModule.kt
RetrofitModule.kt
StorageModule.kt
StorageModule.kt
ThirdScreen.kt
UpdateFirstTimeLaunchPreferencesUseCase.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
proguard-rules.pro

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@luongvo luongvo force-pushed the chore/refactor-project-packages branch from 2b09924 to aee2064 Compare October 31, 2023 10:37
@luongvo luongvo changed the title [POC] Refactor: data module packages [#549] Refactor: data module packages Oct 31, 2023
@luongvo luongvo temporarily deployed to template-compose October 31, 2023 10:41 — with GitHub Actions Inactive
@luongvo luongvo marked this pull request as ready for review October 31, 2023 10:43
@luongvo luongvo added this to the 3.26.0 milestone Oct 31, 2023
@luongvo luongvo linked an issue Oct 31, 2023 that may be closed by this pull request
@luongvo luongvo temporarily deployed to template-compose October 31, 2023 11:01 — with GitHub Actions Inactive
@luongvo luongvo temporarily deployed to template-compose November 22, 2023 01:42 — with GitHub Actions Inactive
@luongvo luongvo requested a review from ryan-conway November 22, 2023 01:43
@ryan-conway ryan-conway merged commit df2fc0b into develop Nov 24, 2023
3 checks passed
@ryan-conway ryan-conway deleted the chore/refactor-project-packages branch November 24, 2023 09:41
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: data module packages
4 participants