Early fail for nodejs versions >= 15 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
reviewed
Mar 22, 2022
infinisil
force-pushed
the
nodejs15-early-exit
branch
from
2673eb2 to
19747fc
Compare
nodejs versions >= 15 use npm >= 7, which uses a new lockfile version that's currently not supported by npmlock2nix. Hook scripts, which npmlock2nix relies on are also removed
infinisil
force-pushed
the
nodejs15-early-exit
branch
from
19747fc to
b5d0baa
Compare
andir
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs versions >= 15 use npm >= 7, which uses a new lockfile version that's currently not supported by npmlock2nix. Early exit until that's implemented. See #146
From the current open issues, this will make the failures in #140 and #139 happen early during eval time