Authentication support #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more flexibility for the future, such as support for: - Source patches - Fetch authentication
For future authentication support
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-29/18903/1 |
|
@infinisil Darn it, this is was a feature I kind of needed. What do you recommend instead of this branch? |
|
@elmarsto Not using npmlock2nix right now unfortunately. Feel free to use my code though for a new PR or fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement npm registry authentication, allowing access to private registries via
.npmrcThis PR also includes the first two commits from #151 since the same changes are needed for authentication support.
Unfortunately the NixOS VM test for authentication created in this PR can't run in GitHub Actions, but it works locally.
TODO:
.npmrcfields_authTokenand_auth_authToken.npmrcfields_passwordandusername(this might not be possible)package-lock.jsonand.npmrcgenerated by npm (the current one is hand-written)npmwith the example from the current test.npmrc, see https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc