Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for node >15 and npm>7 attempt #2 #165

Closed
wants to merge 27 commits into from

Conversation

tlxzilia
Copy link
Contributor

Should now completely fixes #153.

tlxzilia added 23 commits August 2, 2022 15:59
…med unstable as integrity field wasn't populated under correct attribute. A solution with nix substutiteAll could not handle large number of overrided dependencies.
…ssign them to "latest" package dependencies definition. having latest as a version cause npm to try to resolve from registry.
@tlxzilia tlxzilia marked this pull request as ready for review August 15, 2022 04:06
@deemp
Copy link

deemp commented Aug 31, 2022

Hi, @tlxzilia! With

$ which node
/nix/store/6yrgl6gc40938pmax3yd6xabl2mqmk70-nodejs-16.17.0/bin/node

, I get

error: [npmlock2nix] npm lockfile V2 require nodejs version >= 15, it is not supported by nodejs 14.20.0
(use '--show-trace' to show detailed location information)

@andir, could you please check this PR?

@tlxzilia
Copy link
Contributor Author

tlxzilia commented Sep 1, 2022

@br4ch1st0chr0n3 Did you provide a nodejs attribute in your build/shell attributes?
npmlock2nix.build { nodejs = pkgs.nodejs-16_x; }

We might want to bump default version from pkgs.nodejs-14_x to pkgs.nodejs-16_x.

@andir
Copy link
Collaborator

andir commented Nov 21, 2022

I'll close this in favor of #166 as the discussion has moved on there and it is based on this work. Thank you for the work @tlxzilia I really want this to land but as discussed in the other PR there needs to be a tiny bit more of work before I can merge this.

@andir andir closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nodejs >= 15, npm >= 7, lockfile version >= 2
3 participants