-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. #1654
Conversation
bors r+ |
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller Expand accept4 support to more platforms. Co-authored-by: Ryan Zoeller <[email protected]>
Timed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors retry
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller Expand accept4 support to more platforms. Co-authored-by: Ryan Zoeller <[email protected]>
@rtzoeller I think bors is failing because there's no successful build for ""Linux armv7 uclibceabihf", which is in master's bors.toml but not this branch's. But this branch's .cirrus.yml is the one that is getting built. So perhaps rebasing would fix it? |
I'll give that a shot in a few hours when I get home. Thanks! |
Canceled. |
bors retry |
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller Expand accept4 support to more platforms. Co-authored-by: Ryan Zoeller <[email protected]>
I don't see anything wrong in that PR. It looks to me like it might be a bors problem. See https://app.bors.tech/batches/193727 . It doesn't think that any builds have finished yet. |
@asomers did bors' permissions/connection to access nix-rust/nix get reset somehow? I.e. at https://github.com/apps/bors |
No, the configuration looks correct to me. |
@notriddle do you have any insight into what could be happening here? We're seeing bors show all jobs as running (e.g. in https://app.bors.tech/batches/193727), but none ever completing, leading to attempts timing out. Thanks! |
I opened a thread on the bors forum. If we can't get any help for a couple of days, I think we'll just have to start using the old-fashioned merge button. https://forum.bors.tech/t/bors-not-getting-build-notifications-for-nix-rust-nix/632 |
Timed out. |
bors r=rtzoeller |
🔒 Permission denied Existing reviewers: click here to make notriddle a reviewer |
bors r=rtzoeller |
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller Expand accept4 support to more platforms. Co-authored-by: Ryan Zoeller <[email protected]>
I poked around through the API, but this really looks like a CI problem, and not a bors problem. |
Thanks for the investigation @notriddle! And indeed, https://cirrus-ci.com/build/4744058793885696 shows the following error text:
I found cirruslabs/cirrus-ci-docs#972 which is reporting the same error, but with no resolution. |
Timed out. |
Fedor Korotkov said it's fixed. Let's find out. bors retry |
Expand accept4 support to more platforms.