-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for loongarch64 #1738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's difficult for the nix maintainers to validate changes for platforms which are not supported by rustc
, including ensuring they don't immediately regress in support as part of other changes. I see that there is a PR up adding support to rustc
for loongarch64-unknown-linux-gnu
; this change is likely gated on that PR and until loongarch64-unknown-linux-gnu
is supported as at least a Tier 3 target by the Rust compiler.
Once loongarch64-unknown-linux-gnu
is supported as a Tier 3 target by rustc
, I'd like to see it added to our CI pipeline as part of this PR, so we can ensure the support doesn't regress. #1603 is a good example of the changes needed. Note that it'd be added to the Tier 3 section of README.md
, not Tier 1.
thank you very much for your suggestion, I have moved |
We will use |
eb80bd8
to
20df092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please just wait until rust-lang/rust#96971 is merged and released, otherwise the code here would be still useless at best, or require further changes if things change at the Rust side.
.cirrus.yml
Outdated
@@ -288,6 +288,9 @@ task: | |||
- name: Haiku x86_64 | |||
env: | |||
TARGET: x86_64-unknown-haiku | |||
- name: Loongnix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Loongnix is old-world but here it's 100% sure this should be running on a new-world distro. This could be just Linux loongarch64 lp64d
, and any adaptations for Loongnix should be done in your downstream fork specifically for Loongnix, not here.
c95fd7c
to
479b27e
Compare
Signed-off-by: Wenlong Zhang <[email protected]>
479b27e
to
ae718d7
Compare
Thans for your review, i just rebase the code, I whill wait until rust-lang/rust#96971 is merged and released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enough time has passed that LoongArch is already pretty well supported by Rust 1.72.0, so this PR could get a rebase?
@@ -288,6 +288,9 @@ task: | |||
- name: Haiku x86_64 | |||
env: | |||
TARGET: x86_64-unknown-haiku | |||
- name: Linux loongarch64 lp64d | |||
env: | |||
TARGET: loongarch64-unknown-linux-gnuf64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're back to using loongarch64-unknown-linux-gnu
in the final iteration of rust-lang/rust#96971, so the tuple should get restored here.
@@ -86,6 +86,7 @@ Tier 3: | |||
* x86_64-unknown-linux-gnux32 | |||
* x86_64-unknown-openbsd | |||
* x86_64-unknown-redox | |||
* loongarch64-unknown-linux-gnuf64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're now Tier 2 with host tools, so please move the (corrected) tuple here to the appropriate location too.
Ah, so an equivalent change was already merged in #2045. This can be safely closed then. |
No description provided.