Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with smaller routes file #166

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

MrHinsh
Copy link
Member

@MrHinsh MrHinsh commented Nov 25, 2024

🔧 (main.yaml): disable BuildApi job and fix jq command for merging configs
📝 (publish-redirects.html): comment out unused redirect logic for clarity

The BuildApi job is temporarily disabled by setting its condition to false, likely for testing or maintenance purposes. The jq command is corrected to include the $routesConfig file, ensuring all necessary configurations are merged. In the publish-redirects.html file, the redirect logic is commented out, indicating it is not currently needed but preserved for potential future use. This improves the clarity and maintainability of the code.

…nfigs

📝 (publish-redirects.html): comment out unused redirect logic for clarity

The BuildApi job is temporarily disabled by setting its condition to false, likely for testing or maintenance purposes. The jq command is corrected to include the $routesConfig file, ensuring all necessary configurations are merged. In the publish-redirects.html file, the redirect logic is commented out, indicating it is not currently needed but preserved for potential future use. This improves the clarity and maintainability of the code.
…eadability

The comment block formatting is adjusted to ensure that the closing
comment tag is aligned correctly. This change improves the readability
and maintainability of the code by ensuring that the comment structure
is clear and consistent.
The BuildApi step is removed from the dependencies of the Publish Site job. This change is made because the API build is no longer required for the site publishing process, streamlining the workflow and reducing unnecessary steps.
…workflow

The download of a single artifact is now conditionally disabled by
setting the `if` condition to `${{ false }}`. This change is made to
prevent unnecessary downloading of artifacts during the workflow
execution, which can save time and resources if the artifact is not
needed for the current workflow run.
@nkdagility-actions-bot
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-pond-042d21b03-166.westeurope.5.azurestaticapps.net

The route and redirect mappings were reversed, causing incorrect
redirect behavior. By swapping the values, the correct URL is now
redirected to the intended target, ensuring users are directed to
the correct course pages. This change resolves navigation issues
and improves user experience.
@nkdagility-actions-bot
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-pond-042d21b03-166.westeurope.5.azurestaticapps.net

@MrHinsh MrHinsh merged commit 770c714 into main Nov 25, 2024
7 checks passed
@MrHinsh MrHinsh deleted the staticwebapp.config.routes.json branch November 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant