Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in to_json #2872

Merged
merged 9 commits into from
Jul 16, 2021
Merged

Fix memory leak in to_json #2872

merged 9 commits into from
Jul 16, 2021

Conversation

nlohmann
Copy link
Owner

Fixes #2865.

@nlohmann nlohmann self-assigned this Jul 15, 2021
@nlohmann nlohmann marked this pull request as draft July 15, 2021 07:03
@coveralls
Copy link

coveralls commented Jul 15, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3e4723a on issue2865 into c9c5c01 on develop.

@nlohmann
Copy link
Owner Author

(I started with a regression test to make sure the CI will detect such issues in the future. And indeed, Valgrind and ASAN noticed the leak.)

@nlohmann nlohmann marked this pull request as ready for review July 15, 2021 18:39
@nlohmann nlohmann mentioned this pull request Jul 15, 2021
Closed
3 tasks
@nlohmann nlohmann added this to the Release 3.9.2 milestone Jul 15, 2021
@nlohmann nlohmann merged commit f883ddd into develop Jul 16, 2021
@nlohmann nlohmann deleted the issue2865 branch July 16, 2021 04:52
artificiel added a commit to artificiel/apothecary that referenced this pull request Apr 5, 2023
@artificiel
Update aging nlohmann::json to current version.
28e3933 
Been bitten by this:

nlohmann/json#2872
@artificiel artificiel mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.

ASAN detects memory leaks
3 participants
@nlohmann @coveralls @gregmarr