-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix global UDLs #3646
Fix global UDLs #3646
Conversation
As expected, the tests are failing now without the fix. |
cb2b535
to
eb2952b
Compare
I'm switching from using namespace nlohmann::literals::json_literals; to using nlohmann::literals::json_literals::operator""_json;
using nlohmann::literals::json_literals::operator""_json_pointer; (in Still requires |
eb2952b
to
3763bc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I have one more minor documentation tweak, but I'm waiting for CI to pass. I'm adding this to the top of the lists of recommended ways to bring the UDL operators into scope: using nlohmann::literals::operator "" _json[_pointer]; |
I find the using nlohmann::literals::operator "" _json;
using nlohmann::literals::operator "" _json_pointer; |
Sorry for messing this one up in the first place. Really don't know how it happened. Maybe I forgot to cherry-pick the most important commit... |
Unfortunately, GCC 4.8 complains. |
Each file gets the correct line. :-) |
No problem at all! You contributed so much to this release! |
3763bc3
to
fdc8e6e
Compare
I think I fixed it. Works on Compiler Explorer (GCC 4.8.1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Really default
JSON_GLOBAL_UDLS
to1
(oops) and modify tests to catch this error.Fixes #3644.
Fixes #3645.