Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to platform-tools-35.0.2 #157

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Upgrade to platform-tools-35.0.2 #157

merged 2 commits into from
Aug 11, 2024

Conversation

Biswa96
Copy link
Collaborator

@Biswa96 Biswa96 commented Aug 11, 2024

No description provided.

@Biswa96
Copy link
Collaborator Author

Biswa96 commented Aug 11, 2024

The build fails with the following error in Ubuntu 20.04 probably due to older protobuf version.

app_processes.proto:29:14: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.

Can I upgrade Ubuntu version to 22.04 or 24.04 or remove it ?

@Biswa96
Copy link
Collaborator Author

Biswa96 commented Aug 11, 2024

Build fails in Ubuntu 22.04 using protoc version 3.12.4 with the following error.

app_processes.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.

Ubuntu 20.04 fails to build with protoc 3.6.1.3.
app_processes.proto:29:14: Explicit 'optional' labels are disallowed in the Proto3 syntax.
To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.

Ubuntu 22.04 fails to build with protoc 3.12.4.
app_processes.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.

clang-14 in Ubuntu fails to build.
chrono:2360:48: error: call to consteval function 'std::chrono::hh_mm_ss::_S_fractional_width' is not a constant expression
chrono:2360:48: note: undefined function '_S_fractional_width' cannot be used in a constant expression
@Biswa96 Biswa96 merged commit 7cb4b93 into nmeum:master Aug 11, 2024
14 checks passed
@Biswa96 Biswa96 deleted the 35.0.2 branch August 11, 2024 09:09
@Biswa96
Copy link
Collaborator Author

Biswa96 commented Aug 29, 2024

Would it be better to release a tag now if there is no issue with this upgrade?

@anatol
Copy link
Collaborator

anatol commented Aug 29, 2024

Yes, please. Let's do a new tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants