Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make temperature i32 instead of u32, because you know, it can get cold #14

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Make temperature i32 instead of u32, because you know, it can get cold #14

merged 1 commit into from
Jan 23, 2021

Conversation

twistedfall
Copy link
Contributor

@twistedfall twistedfall commented Jan 9, 2021

My mistake from the previous pull request, found out about it today when it got cold outside :)

@nn1ks
Copy link
Owner

nn1ks commented Jan 9, 2021

Thanks!
BTW The build errors are unrelated to your changes. I already submitted a PR upstream but I'll have to wait to merge this PR until a new version of derive_setters is released.

@nn1ks nn1ks merged commit de2f427 into nn1ks:master Jan 23, 2021
@nn1ks
Copy link
Owner

nn1ks commented Jan 23, 2021

Sorry for taking so long to merge this pull request. The upstream PR I opened has not been merged yet so I pinned the syn version to a specific version for now (d0dc399). Let me know if you want me to release a new version.

@twistedfall
Copy link
Contributor Author

No pressure :) I’m using the local fork with that fix applied atm

@nn1ks
Copy link
Owner

nn1ks commented Jan 23, 2021

Okay :) In that case I'll probably implement a different feature first, before I release a new version (but that shouldn't take too long, I will try to finish it tomorrow).

@nn1ks
Copy link
Owner

nn1ks commented Jan 24, 2021

It's now available in version 0.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants