You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.
Currently the index.js says the default theme should be 'default'. However, this default always overwrites the provided 'theme' you actually want.
It currently says the following: var opts = defaults({ theme: 'default' }, options);
However, since we want to use our own theme, it should be the other way around otherwise it gets always overwritten by 'default':
var opts = defaults(options, { theme: 'default' });
Is there any specific reason why you set it explicitly to 'default'? If not, can you please provide the fix so it only falls back to the 'default' when there is no theme provided?
The text was updated successfully, but these errors were encountered:
ReneS1991
added a commit
to cmnty/gulp-aglio
that referenced
this issue
Mar 20, 2017
Currently the index.js says the default theme should be 'default'. However, this default always overwrites the provided 'theme' you actually want.
It currently says the following:
var opts = defaults({ theme: 'default' }, options);
However, since we want to use our own theme, it should be the other way around otherwise it gets always overwritten by 'default':
var opts = defaults(options, { theme: 'default' });
Is there any specific reason why you set it explicitly to 'default'? If not, can you please provide the fix so it only falls back to the 'default' when there is no theme provided?
The text was updated successfully, but these errors were encountered: