Skip to content
This repository has been archived by the owner on Jul 21, 2020. It is now read-only.

Theme gets always overwritten by 'default' #14

Open
ReneS1991 opened this issue Mar 20, 2017 · 0 comments
Open

Theme gets always overwritten by 'default' #14

ReneS1991 opened this issue Mar 20, 2017 · 0 comments

Comments

@ReneS1991
Copy link

Currently the index.js says the default theme should be 'default'. However, this default always overwrites the provided 'theme' you actually want.

It currently says the following:
var opts = defaults({ theme: 'default' }, options);

However, since we want to use our own theme, it should be the other way around otherwise it gets always overwritten by 'default':

var opts = defaults(options, { theme: 'default' });

Is there any specific reason why you set it explicitly to 'default'? If not, can you please provide the fix so it only falls back to the 'default' when there is no theme provided?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant