Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect File.seperator use - broken on Windows. #32

Merged
merged 1 commit into from
May 2, 2020

Conversation

nich0s
Copy link
Contributor

@nich0s nich0s commented May 1, 2020

On Windows:

[...]
    GET           /v1/openapi/*                [*/*]                     [*/*]                     (OpenAPIService._)    
    GET           /v1/openapi/redoc            [*/*]                     [text/html]               (OpenAPIService._)    
    GET           /v1\openapi.yaml             [*/*]                     [text/yaml]               (OpenAPIService._) 
[...]   

On Windows:
```
    GET           /v1/openapi/*                [*/*]                     [*/*]                     (OpenAPIService._)    
    GET           /v1/openapi/redoc            [*/*]                     [text/html]               (OpenAPIService._)    
    GET           /v1\openapi.yaml             [*/*]                     [text/yaml]               (OpenAPIService._)    
```
@nich0s nich0s closed this May 1, 2020
@nich0s nich0s reopened this May 1, 2020
@nich0s
Copy link
Contributor Author

nich0s commented May 1, 2020

Howdy - sorry about the terseness of this. I wrote it when I was pre-coffee this morning. The reasoning behind the PR is that it appears that File.seperator is being called and the resulting value is being used to set the path template for YAML lookup. This fails on Windows resulting with the above.

@nich0s nich0s changed the title Incorrect File.sep() use - broken on Windows. Incorrect File.seperator use - broken on Windows. May 2, 2020
@noboomu noboomu merged commit eb514fe into noboomu:master May 2, 2020
@noboomu
Copy link
Owner

noboomu commented May 2, 2020

All good :) Thank you.

@nich0s nich0s deleted the patch-1 branch May 3, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants