.mp3 files uploaded with dataBrowser as .mp3$.mp3

[bourgeoa]

see SolidOS/folder-pane#5 from @timbl

resource-mapper is creating the file foo.mp3 as foo.mp3$.mp3
contentType of .mp3 is audio/mpeg but iana extension for audio/mpeg is mpga.

So the check is a false wrong match and resource-mapper is creating foo.mp3$.mp3
I think it should be foo.mp3

It can be generalized so that resource-mapper.mapUrlToFile returns foo.ext and not foo.ext$.ext

[jaxoncreed]

This is a pretty bad problem. Would you like to make a pull request with a fix? Otherwise, I'll get around to fixing this.

[bourgeoa]

I am traveling until tomorrow and moving my server, so cannot propose anything today. If you don't fix it before I shall try to propose a PR tomorrow Le mer. 16 oct. 2019 à 21:17, jaxoncreed <[email protected]> a écrit :

…

This is a pretty bad problem. Would you like to make a pull request with a fix? Otherwise, I'll get around to fixing this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1318>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQ5TZRNLWWRSY75FUMDJ7TQO5SEFANCNFSM4JA7R3GA> .hi

[jaxoncreed]

@bourgeoa I cannot reproduce this. Could you send me the CURL of the request and the configuration of your NSS

[bourgeoa]

I am using NSSv5.2.0 on a docker installation https://alain.bourgeoa.ga/public/music/
there are 3 files created using the + button from the databrowser.
I join a copy of the files in the filesystem. As you can see there is a $.mp3 extension to the mp3 file

I don't use curl. Can you send me an example.

I am finalizing a PR fix. I must first build and test it on my server
it takes in consideration that the file extension as to be one of the allowed extensions for the contentType and not only the first one as it is actually done.

[Ryuno-Ki]

You can use the context menu in Network Monitor to copy a request as cURL.

[jaxoncreed]

If you're already working on a fix, then that's fine. But for future reference, as @Ryuno-Ki pointed out, you can usually right-click on the request and copy it as CURL

[bourgeoa]

see PR #1328