Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: introduce ci #16

Open
wants to merge 2 commits into
base: devlop
Choose a base branch
from
Open

workflow: introduce ci #16

wants to merge 2 commits into from

Conversation

AugustinMauroy
Copy link
Member

close #6

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:33

  • The command 'node --run types:check' seems incorrect. It should likely be 'npm run types:check' or 'yarn run types:check'.
run: node --run types:check

.github/workflows/ci.yml:51

  • Ensure that the 'test:unit' script is covered by tests and is executed correctly.
run: node --run test:unit

push:
branches: [ "main" ]
pull_request:
# we use devlop branch for now before publishing the website
Copy link
Preview

Copilot AI Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'devlop' is misspelled. It should be 'develop'.

Suggested change
# we use devlop branch for now before publishing the website
# we use develop branch for now before publishing the website

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's deliberate the branch uses a shortened name

@AugustinMauroy AugustinMauroy linked an issue Feb 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflows: continuous testing on pr/main branch
1 participant