Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mothballing and archiving the node-eps process #335

Closed
jasnell opened this issue Sep 6, 2017 · 15 comments
Closed

Mothballing and archiving the node-eps process #335

jasnell opened this issue Sep 6, 2017 · 15 comments

Comments

@jasnell
Copy link
Member

jasnell commented Sep 6, 2017

@nodejs/tsc: For those who are not familiar with the term: mothballing == to stop using (a piece of equipment or a building) but keep it in good condition so that it can readily be used again.

Essentially, the nodejs/node-eps process has not been an overly successful process. The conversations there tend to get lost in the weeds, fail to progress, and attract trolling and bad behavior. The process of just setting up a working fork or working via a PR has been extremely successful in comparison (see URL, http2, n-api, node-chakracore, @bmeck's ESM PR, all for good examples).

The nodejs/node-eps approach never really got the love it needed from the TSC/CTC to be successful. I'm proposing that we archive the repo and no longer push it as a recommended process.

@Trott
Copy link
Member

Trott commented Sep 7, 2017

SGTM

1 similar comment
@mcollina
Copy link
Member

mcollina commented Sep 7, 2017

SGTM

@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 7, 2017 via email

@thefourtheye
Copy link
Contributor

SGTM

@mhdawson
Copy link
Member

mhdawson commented Sep 8, 2017

I wish we had an alternative but seeing how little love it has received SGTM for now.

@jasnell
Copy link
Member Author

jasnell commented Sep 12, 2017

@nodejs/tsc ... we need more tsc members to weigh in.

@bnoordhuis
Copy link
Member

One more SGTM for the collection.

@targos
Copy link
Member

targos commented Sep 12, 2017

SGTM

@evanlucas
Copy link
Contributor

I like that idea

@Trott
Copy link
Member

Trott commented Sep 12, 2017

@nodejs/tsc ... we need more tsc members to weigh in.

No one objected. 5 members besides you gave it the thumbs up. It was open for 5 days and TSC was @-notified immediately when the issue was opened.

That's consensus. Someone who hasn't spoken up by now can be considered a "no objection" and/or "no opinion".

(And now you have three more approvals! Four more if you include Joyee's thumbs up reaction.)

@jasnell
Copy link
Member Author

jasnell commented Sep 13, 2017

Indeed, I'm happy to call it in favor of the proposal. It would just be helpful if all 22 TSC members would generally be more proactive about weighing in on such issues. As it is, assuming we're moving forward with this, I will open a PR against the nodejs/node-eps repo updating the README to say that it is archived and will open an issue there communicating the same.

@jasnell
Copy link
Member Author

jasnell commented Sep 13, 2017

Closing as the issue appears to be resolved.

@jasnell jasnell closed this as completed Sep 13, 2017
@Trott Trott removed the tsc-review label Sep 13, 2017
@Fishrock123
Copy link
Contributor

... I am not for this. I think it is useful and it should be used more.

@ofrobots
Copy link
Contributor

I thought I had commented on this already. Here's post-closing +1 on this proposal.

richardlau added a commit to richardlau/node-1 that referenced this issue Sep 28, 2018
https://github.com/nodejs/node-eps has been archived and new proposals
can no longer be opened there. Remove the corresponding recommendation
to use it.

Refs: nodejs/TSC#335
danbev pushed a commit to nodejs/node that referenced this issue Oct 2, 2018
https://github.com/nodejs/node-eps has been archived and new proposals
can no longer be opened there. Remove the corresponding recommendation
to use it.

PR-URL: #23148
Refs: nodejs/TSC#335
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Oct 3, 2018
https://github.com/nodejs/node-eps has been archived and new proposals
can no longer be opened there. Remove the corresponding recommendation
to use it.

PR-URL: #23148
Refs: nodejs/TSC#335
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@SamB
Copy link

SamB commented Jun 21, 2019

Um ... shouldn't you have left a note about where to go instead at https://github.com/nodejs/node-eps#readme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests