-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reach out to top 30 modules owners #245
Comments
This list will be easier to use: |
Issue for node-serialport - serialport/node-serialport#1186 |
Issue for nodegit - nodegit/nodegit#1298 |
Issue for hiredis - redis/hiredis-node#134 |
Issue for bcrypt - kelektiv/node.bcrypt.js#513 |
Issue for node-sqlite3 - TryGhost/node-sqlite3#830 |
Issue for websocket - theturtle32/WebSocket-Node#284 |
Talked to Francis today about Node Serial port. He is happy to have a branch in the repo and help maintain once there is a port. He sees definite benefits in that today he needs to support downloading because there has to be a different binary for every version of Node.js and the sum of those are too big to bundle into an npm. With a single binary bundling would be possible. The plan is for me to take a first cut at porting, he's available to support us by answering questions etc. Once we have an initial cut we'll get back together to get it into a branch in the repo and figure out the plan going forward. |
Hello, I started to investigate porting theturtle32/WebSocket-Node#284 to N-API. After some research I found out the original code for the native modules were extracted of ws. Today this code is in the packages bufferutil and utf-8-validate as opt-in dependencies for ws. I ported both packages to N-API: andreek/bufferutil / andreek/utf-8-validate. My recommendation regarding to theturtle32/WebSocket-Node#284 is to use bufferutil / utf-8-validate. I could use some help reaching the maintainers of websocket/bufferutil / websocket/utf-8-validate (33/34 on list) talking them into having a N-API branch. But I don't know if there is any strategy. I was thinking about just creating PRs and asking for creating a separate branch to maintain. I hope its the right place to give feedback and ask for some help. |
@andreek thanks for your work. What we have done in the past is created a PR explaining the context of why they want to move to N-API, the branch were the port has been done. Our guidance on how to have an N-API for now is in https://nodejs.org/en/docs/guides/publishing-napi-modules/ Would like like to come to our next N-API interlock (Thursdays at 1:30 EST) so we can discuss how to help reaching the maintainers and maybe you can give us an overview of your thoughts on the API having done the port ? |
@mhdawson yeah, I would like to. The hangout link in the readme is still used? |
@andreek yes the same link as in the readme. It is also in the foundation calendar entry. |
websockets/bufferutil#81 / websockets/utf-8-validate#54 merged into n-api branch. For theturtle32/WebSocket-Node#284 PR theturtle32/WebSocket-Node#302 is open to depend on n-api modules. |
Also libqrencode partialy translated to the n-api approach. |
Hi everyone, I just ended the porting of hiredis and I provided to update the issue on the repo if hiredis redis/hiredis-node#134 (comment) |
I think we are past this effort and we should open a new issue if we decided to do more outreach to larger modules. |
The text was updated successfully, but these errors were encountered: