Port to N-API #54
Merged
Port to N-API #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The feature is still experimental so no, not yet. |
lpinca
reviewed
Dec 2, 2017
binding.gyp
Outdated
| 'include_dirs': ["<!(node -e \"require('nan')\")"], | ||
| 'cflags!': [ '-fno-exceptions' ], | ||
| 'cflags_cc!': [ '-fno-exceptions' ], | ||
| 'xcode_settings': { 'GCC_ENABLE_CPP_EXCEPTIONS': 'YES', |
There was a problem hiding this comment.
This should probably be merged with the other xcode_settings below.
fallback.js
Outdated
| @@ -16,6 +16,11 @@ | |||
| * @public | |||
| */ | |||
| const isValidUTF8 = (buf) => { | |||
|
|
|||
| if (!buf) { | |||
There was a problem hiding this comment.
Not needed, Buffer.isBuffer() covers this.
|
Updated description to be more clear about creating a branch instead of merging against master. |
|
Yes, the branch is called |
andreek
force-pushed
the
master
branch
2 times, most recently
from
ddda467 to
5851321
Compare
lpinca
reviewed
Dec 3, 2017
src/validation.cc
Outdated
| } | ||
|
|
||
| void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) { | ||
| Nan::SetMethod(module, "exports", isValidUTF8); | ||
| Napi::Object Init(Napi::Env env, Napi::Object exports) { |
There was a problem hiding this comment.
Make it static and call it init for consistency with bufferutil?
- removed nan dependency - add node-addon-api dependency - port validation.cc to N-API
|
Git history seems to be working now. But dates are not linear. I don't know if this worries you. Applied latest review change. |
|
Thank you. |
lpinca
pushed a commit
that referenced
this pull request
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test case for no argument givenSince node 8 there is a new experimental feature called N-API which is aimed at reducing maintenance cost for node native addons. Checkout this blog/talk for more details on its benefits.
Edit:
utf-8-validate is one of the top 35 native modules by dependency count. I used this native module first as playground to get my hands on N-API. The port to N-API is now working pretty good so I like to share this code. This should not be merged into master. N-API is still a experimental feature. It would be useful to have a napi branch. The work group is asking for feedback from productive running systems. It would be nice if this branch could be published to npm registry. Here is a guide on how to do that. But its up to you if you want to support this feature in experimental state.