Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI lock-down for 27th security release #1594

Closed
rvagg opened this issue Nov 23, 2018 · 13 comments
Closed

CI lock-down for 27th security release #1594

rvagg opened this issue Nov 23, 2018 · 13 comments

Comments

@rvagg
Copy link
Member

rvagg commented Nov 23, 2018

CI is going to be locked down while we prepare for next week's security release. My current plan is to remove collaborator and public access tomorrow evening, the 23rd, USA time. It'll be opened back up again as soon as the security releases are out. Travis will not be impacted, and I'm not yet sure what the impact will be on the bot requesting lite tests for Collaborator PRs but I think that should be disabled too.

@nodejs/collaborators @nodejs/build

@refack
Copy link
Contributor

refack commented Nov 23, 2018

The bot uses a collaborator level access token so by default it will get disabled.
If we could have a segregated section of the GUI that only displays the lite jobs, we might be able to consider leaving just that open.
But I have no idea if we can do that, and/or how.
So for this week I think we should keep the bot disabled.

@mcollina
Copy link
Member

May I retain access? I think I can be of help for this specific release m, as I worked on several of the fixes.

@mhdawson
Copy link
Member

@mcollina that sounds reasonable, @rvagg can probably add you to the matrix to allow that.

@rvagg
Copy link
Member Author

rvagg commented Nov 24, 2018

I'm still pulling together releases and am good with local testing for now so I think I'll defer this until tomorrow. Depending on how my day goes, it may be up to 24 hours from now. So feel free to keep using CI for your excellent work collaborators!

@refack
Copy link
Contributor

refack commented Nov 24, 2018

Heads up nodejs/code-and-learn#92

@rvagg
Copy link
Member Author

rvagg commented Nov 25, 2018

before:

screenshot 2018-11-26 02 27 23

after:
screenshot 2018-11-26 02 30 12

(added the nodejs/security group, I think I'll leave that after this for convenience)

@refack
Copy link
Contributor

refack commented Nov 25, 2018

I added discover to nodejs/releasers and nodejs/security to try to resolve a issue reported by @mcollina
image

P.S. security team might be too abstracts. Had to add @mcollina explicitly.

@sam-github
Copy link
Contributor

@refack I believe two groups have access to the private security repos/issues: the security team, and the TSC -- and @mcollina has auth via the latter. I'm not sure how the TSC organizes themselves, maybe they don't all want to get notifications for @nodejs/security, and those who do should be explicitly added to nodejs/security?

@mcollina
Copy link
Member

@sam-github I'm also part of the security team.

@sam-github
Copy link
Contributor

Hm, I wonder what @refack meant by this?

P.S. security team might be too abstracts. Had to add @mcollina explicitly.

@refack
Copy link
Contributor

refack commented Nov 26, 2018

believe two groups have access to the private security repos/issues: the security team, and the TSC

AFAICT the GitHub nodejs/security team is composed of 4 sub-teams
https://github.com/orgs/nodejs/teams/security:

Teams 4
security-external
Meta-team for external members of the security team

6 members • 0 teams
security-release
Meta-team for releasers who are all in the security team

10 members • 0 teams
security-triage
Meta-team for members of the security triage team

7 members • 0 teams
security-tsc
Meta-team for TSC members who are all in the security team

17 members • 0 teams

But apparently the Jenkins GitHub-auth plugin doesn't understand that properly ¯\(ツ)

P.S. I'm online most of today, if anyone else needs access.

@refack
Copy link
Contributor

refack commented Nov 26, 2018

Hm, I wonder what @refack meant by this?

P.S. security team might be too abstracts. Had to add @mcollina explicitly.

I meant two things:

  1. It's not working for Jenkins.
  2. It seems too broad for me to add all 4 sub-teams, without further consultation.

@rvagg
Copy link
Member Author

rvagg commented Nov 28, 2018

jenkins_post_nov_release_perms

CI lockdown should be lifted now

@rvagg rvagg closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants