-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI lock-down for 27th security release #1594
Comments
The bot uses a collaborator level access token so by default it will get disabled. |
May I retain access? I think I can be of help for this specific release m, as I worked on several of the fixes. |
I'm still pulling together releases and am good with local testing for now so I think I'll defer this until tomorrow. Depending on how my day goes, it may be up to 24 hours from now. So feel free to keep using CI for your excellent work collaborators! |
Heads up nodejs/code-and-learn#92 |
I added discover to nodejs/releasers and nodejs/security to try to resolve a issue reported by @mcollina P.S. |
@refack I believe two groups have access to the private security repos/issues: the security team, and the TSC -- and @mcollina has auth via the latter. I'm not sure how the TSC organizes themselves, maybe they don't all want to get notifications for |
@sam-github I'm also part of the security team. |
AFAICT the GitHub
But apparently the Jenkins GitHub-auth plugin doesn't understand that properly ¯\(ツ)/¯ P.S. I'm online most of today, if anyone else needs access. |
CI is going to be locked down while we prepare for next week's security release. My current plan is to remove collaborator and public access tomorrow evening, the 23rd, USA time. It'll be opened back up again as soon as the security releases are out. Travis will not be impacted, and I'm not yet sure what the impact will be on the bot requesting lite tests for Collaborator PRs but I think that should be disabled too.
@nodejs/collaborators @nodejs/build
The text was updated successfully, but these errors were encountered: