-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add antsmartian to collaborators #24653
Conversation
@antsmartian sadly an error occured when I tried to trigger a build :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you being onboarded? Part of the onboarding process is checking whether you can start builds on the CI, which given the CI is currently locked down for the security releases isn't possible at the moment.
@@ -250,6 +250,8 @@ For information about the governance of the Node.js project, see | |||
* [AnnaMag](https://github.com/AnnaMag) - | |||
**Anna M. Kedzierska** <[email protected]> | |||
* [apapirovski](https://github.com/apapirovski) - | |||
**Anto Aravinth** <[email protected]> (he/him) | |||
* [antsmartian](https://github.com/antsmartian) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've split apapirovski's entry. Please shift one line up and swap the order of the lines so your GitHub username comes first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Thanks for the catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that @antsmartian is being onboarded; revoking my approval until that is confirmed.
@richardlau @gireeshpunathil Yes I was being onboarded. We can wait until the CI lock is released. Just a question, when the lock will be released? |
This is my mistake. Yes, @antsmartian is being onboarded and I was helping him with that. We realized that the CI lock down is active only after creating this PR. |
got clarified from @thefoutheye
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once @richardlau 's suggestion incorporated
I guess post 27th; according to nodejs/build#1594 |
@richardlau @gireeshpunathil @thefourtheye My bad, I ended up creating the branch in node repo, rather than my fork. Gonna close this and open up a new PR. Sorry. |
Adding myself to collaborators list.
Refs: #24340
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes