Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add antsmartian to collaborators #24653

Closed
wants to merge 1 commit into from
Closed

doc: add antsmartian to collaborators #24653

wants to merge 1 commit into from

Conversation

antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Nov 26, 2018

Adding myself to collaborators list.

Refs: #24340

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@antsmartian sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 26, 2018
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you being onboarded? Part of the onboarding process is checking whether you can start builds on the CI, which given the CI is currently locked down for the security releases isn't possible at the moment.

@@ -250,6 +250,8 @@ For information about the governance of the Node.js project, see
* [AnnaMag](https://github.com/AnnaMag) -
**Anna M. Kedzierska** <[email protected]>
* [apapirovski](https://github.com/apapirovski) -
**Anto Aravinth** <[email protected]> (he/him)
* [antsmartian](https://github.com/antsmartian)
Copy link
Member

@richardlau richardlau Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've split apapirovski's entry. Please shift one line up and swap the order of the lines so your GitHub username comes first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks for the catch.

Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that @antsmartian is being onboarded; revoking my approval until that is confirmed.

@antsmartian
Copy link
Contributor Author

@richardlau @gireeshpunathil Yes I was being onboarded. We can wait until the CI lock is released. Just a question, when the lock will be released?

@thefourtheye
Copy link
Contributor

Are you being onboarded? Part of the onboarding process is checking whether you can start builds on the CI, which given the CI is currently locked down for the security releases isn't possible at the moment.

This is my mistake. Yes, @antsmartian is being onboarded and I was helping him with that. We realized that the CI lock down is active only after creating this PR.

@gireeshpunathil gireeshpunathil dismissed their stale review November 26, 2018 10:31

got clarified from @thefoutheye

Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @richardlau 's suggestion incorporated

@gireeshpunathil
Copy link
Member

when the lock will be released?

I guess post 27th; according to nodejs/build#1594

@antsmartian
Copy link
Contributor Author

@richardlau @gireeshpunathil @thefourtheye My bad, I ended up creating the branch in node repo, rather than my fork. Gonna close this and open up a new PR. Sorry.

@antsmartian antsmartian deleted the add-to-doc branch November 26, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants