Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation broken on Windows with VS 17.12 #3963

Closed
StefanStojanovic opened this issue Nov 18, 2024 · 6 comments
Closed

Compilation broken on Windows with VS 17.12 #3963

StefanStojanovic opened this issue Nov 18, 2024 · 6 comments
Assignees
@StefanStojanovic

Comments

@StefanStojanovic
Copy link
Contributor

VS 2022 v17.12 (released Nov 12) cannot compile Node.js with MSVC. I'm working on making a simple reproduceable example to open an issue in developercommunity.visualstudio.com.

cc @nodejs/platform-windows

Refs: #3739
@StefanStojanovic StefanStojanovic self-assigned this Nov 18, 2024
@StefanStojanovic
Copy link
Contributor Author

Here is the developer community issue.

This was referenced Nov 20, 2024
Merged
Closed
StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Nov 20, 2024
@StefanStojanovic
build: avoid compiling with VS v17.12
0585ef1 
Refs: nodejs/build#3963
This was referenced Nov 20, 2024
Merged
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Nov 26, 2024
@StefanStojanovic
build: avoid compiling with VS v17.12
542f252 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this issue Nov 26, 2024
@StefanStojanovic @aduh95
build: avoid compiling with VS v17.12
7133c04 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Flarna
Copy link
Member

Flarna commented Nov 28, 2024

Received 17.12.2 today and it seems problem is fixed there.

@njzjz njzjz mentioned this issue Dec 2, 2024
Closed
@Flarna Flarna mentioned this issue Dec 5, 2024
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Dec 7, 2024
@Flarna
Revert "build: avoid compiling with VS v17.12"
6e42433 
This reverts commit 542f252.

PR-URL: #56151
Refs: nodejs/build#3963
Refs: #55930
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
@targos
Copy link
Member

targos commented Dec 8, 2024

nodejs/node#56151 Landed so I've re-enabled the Windows workflows.

@StefanStojanovic
Copy link
Contributor Author

I plan to unpin Visual Studio version in our CI machines and will close this issue once that is done.

aduh95 pushed a commit to nodejs/node that referenced this issue Dec 10, 2024
@Flarna @aduh95
Revert "build: avoid compiling with VS v17.12"
08e5309 
This reverts commit 542f252.

PR-URL: #56151
Refs: nodejs/build#3963
Refs: #55930
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
@StefanStojanovic
Copy link
Contributor Author

I've updated VS versions to the latest on all test and release CI machines. Will follow it for a few days and close if all is OK.

aduh95 pushed a commit to nodejs/node that referenced this issue Dec 13, 2024
@StefanStojanovic @aduh95
build: avoid compiling with VS v17.12
a910031 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this issue Dec 13, 2024
@StefanStojanovic @aduh95
build: avoid compiling with VS v17.12
3939089 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this issue Dec 13, 2024
@StefanStojanovic @aduh95
build: avoid compiling with VS v17.12
e03be6b 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau mentioned this issue Dec 16, 2024
Closed
@StefanStojanovic
Copy link
Contributor Author

Closing since all is alright in the CI.

marco-ippolito pushed a commit to marco-ippolito/node that referenced this issue Dec 18, 2024
@StefanStojanovic @marco-ippolito
build: avoid compiling with VS v17.12
5eb4e1e 
Refs: nodejs/build#3963
PR-URL: nodejs#55930
Refs: nodejs#53863
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanStojanovic StefanStojanovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @StefanStojanovic @Flarna