Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: on push GitHub Action to lint Python code #1930

Merged
merged 1 commit into from
Sep 30, 2019
Merged

build: on push GitHub Action to lint Python code #1930

merged 1 commit into from
Sep 30, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 27, 2019

Use GitHub Actions to lint Python code with flake8 on both Python 2 and Python 3.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit rubber-stamp-ish of me, but LGTM

@sam-github
Copy link
Contributor

gh actions are the new hotness, it seems, but I don't know that yet a third ci system added to jenkins and travis is really supportable, but we can leave that decision for a bit. I'm sure it will come up.

In the meantime, RSLGTM too .

@rvagg
Copy link
Member

rvagg commented Sep 30, 2019

👍 from me, we're not using travis here so we're not doubling up. The more we exercise GitHub Actions to understand its limitation the better.

@rvagg rvagg merged commit 303e626 into nodejs:master Sep 30, 2019
@rvagg
Copy link
Member

rvagg commented Sep 30, 2019

this is failing https://github.com/nodejs/build/commit/303e626f9d550c70606d95e3cae6ba8287d93793/checks
But I see now that the commit has an additional comment that it's blocked by #1929 (this didn't show up in the PR btw @cclauss, just in the commit summary). If this is the case I suppose we can just wait for to land, presumably soon?

@rvagg
Copy link
Member

rvagg commented Sep 30, 2019

nope, #1929 already landed, so the failure is unexpected then. failed on pip upgrade pip:

ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

@cclauss cclauss deleted the patch-1 branch September 30, 2019 03:35
@cclauss
Copy link
Contributor Author

cclauss commented Sep 30, 2019

Runtime issues resolved in #1934

@richardlau richardlau mentioned this pull request Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants