Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review team access to this repository #945

Closed
BethGriggs opened this issue Mar 16, 2023 · 4 comments
Closed

Review team access to this repository #945

BethGriggs opened this issue Mar 16, 2023 · 4 comments

Comments

@BethGriggs
Copy link
Member

From #944 (comment):

@nodejs/releasers has "Maintain" access, and @nodejs/bots has "Write" access. @nodejs/tsc also has "Write" access, but that should probably be revoked, the TSC doesn't ned any special permissions for this repo AFAICT. Neither @nodejs/citgm nor @nodejs/citgm-admins have any rights on this repo, it's probably a mistake 🤷‍♂️

I think we should review and update team access.

My suggestion would be:

  • Write access for nodejs/citgm*, nodejs/releasers, and nodejs/bots
  • Remove explicitly granted access for nodejs/tsc
    • This seems unnecessary as they're organisation owners.

(I believe the above is in line with @aduh95's comment.)

@richardlau
Copy link
Member

SGTM

@aduh95
Copy link

aduh95 commented Mar 16, 2023

I don’t know if my position matters a lot here as I don’t contribute much to CITGM, but FWIW I usually use « Maintain » rather than « Write » when setting up permissions (e.g. for Corepack, or node-core-test), but the current plan also SGTM.

@BethGriggs
Copy link
Member Author

FWIW I usually use « Maintain » rather than « Write » when setting up permissions (e.g. for Corepack, or node-core-test), but the current plan also SGTM.

Hmm, looking at the access difference, Maintain may be more appropriate. Can people 👍🏻 if the agree to the proposal as above, but switching Write -> Maintain?

@BethGriggs
Copy link
Member Author

Updated as proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants