Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move team list from nodejs/release #944

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

BethGriggs
Copy link
Member

Refs: nodejs/Release#833

Checklist
  • documentation is changed or added
  • contribution guidelines followed
    here

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +3.25 🎉

Comparison is base (9975077) 93.20% compared to head (704d952) 96.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   93.20%   96.46%   +3.25%     
==========================================
  Files          28       28              
  Lines        2149     2149              
==========================================
+ Hits         2003     2073      +70     
+ Misses        146       76      -70     

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ljharb
Copy link
Member

ljharb commented Mar 15, 2023

Does the citgm team not have write access to the citgm repo?

@aduh95
Copy link

aduh95 commented Mar 15, 2023

Does the citgm team not have write access to the citgm repo?

@nodejs/releasers has "Maintain" access, and @nodejs/bots has "Write" access. @nodejs/tsc also has "Write" access, but that should probably be revoked, the TSC doesn't ned any special permissions for this repo AFAICT. Neither @nodejs/citgm nor @nodejs/citgm-admins have any rights on this repo, it's probably a mistake 🤷‍♂️

@BethGriggs BethGriggs merged commit e8a0246 into nodejs:main Mar 20, 2023
@BethGriggs BethGriggs deleted the contributors branch March 20, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants