Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot resolve path when building with EXTERNAL_PATH #93

Merged
merged 1 commit into from
Apr 28, 2024
Merged

fix: cannot resolve path when building with EXTERNAL_PATH #93

merged 1 commit into from
Apr 28, 2024

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Apr 28, 2024

@guybedford guybedford merged commit 8ea767a into nodejs:main Apr 28, 2024
1 check passed
@mochaaP
Copy link
Contributor Author

mochaaP commented Apr 28, 2024

wow that's quick. Thanks!

mochaaP added a commit to mcha-forks/cjs-module-lexer that referenced this pull request Apr 28, 2024
@mochaaP
Revert "fix: cannot resolve path when build with EXTERNAL_PATH (nodej…
40297f5 
…s#93)"

This reverts commit 8ea767a.
@mochaaP
Copy link
Contributor Author

mochaaP commented Apr 28, 2024

Uh, I recalled why this was a thing. It should be import.meta.resolve("../lib/lexer.wasm") for tests to work without globally installing the module.

@mochaaP mochaaP mentioned this pull request Apr 28, 2024
Merged
guybedford pushed a commit that referenced this pull request Apr 28, 2024
@mochaaP
tests: fix loading wasm when targeting external deps (#94)
bcc6ce4 
* tests: fix loading wasm when targeting external deps

* Revert "fix: cannot resolve path when build with EXTERNAL_PATH (#93)"

This reverts commit 8ea767a.
guybedford added a commit that referenced this pull request Apr 28, 2024
@guybedford
Revert "fix: cannot resolve path when build with EXTERNAL_PATH (#93)"
1de1228 
This reverts commit 8ea767a.
guybedford added a commit that referenced this pull request Apr 28, 2024
@guybedford
Revert build changes (#95)
7c74749 
* Revert "tests: fix loading wasm when targeting external deps (#94)"

This reverts commit bcc6ce4.

* Revert "fix: cannot resolve path when build with EXTERNAL_PATH (#93)"

This reverts commit 8ea767a.

* Revert "Support building for externally shared js builtins (#91)"

This reverts commit 1c5072c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mochaaP @guybedford