Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter URL checks #54

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Stricter URL checks #54

merged 2 commits into from
Mar 31, 2019

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Mar 31, 2019

Refs: nodejs/node#26691 (comment)

e.g. for nodejs/node@bdea725

-bash-4.2$ node ../core-validate-commit/bin/cmd.js bdea725
  ✖  bdea725bdcb299579547f66ebcc98af16f53cd16
     ✖  4:7      Fixes must be a GitHub URL.               fixes-url
     ✔  5:7      Valid fixes URL.                          fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  3:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ⚠  0:50     Title should be <= 50 columns.            title-length
-bash-4.2$

Only allow GitHub issue URLs, or comments or discussions from pull
request URLs.
Only allow GitHub pull request URLs.
@richardlau richardlau merged commit de1e8aa into nodejs:master Mar 31, 2019
@richardlau
Copy link
Member Author

Guess I was a bit too strict 😆 : #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants