Skip to content

Commit

Permalink
Editorial updates addressing comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
joshgav committed Jun 7, 2016
1 parent 8bdc0b8 commit 86cce77
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion profiling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

- Heap Profiling
- V8 Heap Profiler: [v8/include/v8-profiler.h](https://github.com/v8/blob/master/include/v8-profiler.h)
- Also accessible through built-in 'v8' module.
- Heap memory usage stats are available through built-in 'v8' module.

Name | Sponsor
-----|--------
Expand Down
2 changes: 1 addition & 1 deletion tracing/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## Tracing
- [AsyncWrap](./AsyncWrap/README.md) - Most native objects are represented indirectly by the [AsyncWrap class](https://github.com/nodejs/node/blob/master/src/async-wrap.h), so hooks have been added to that class to trace lifecycle (init/destroy) and callback activity (pre/post) related to these objects.

- [OS Tracing](./os-tracing/README.md) - LTTng (Linux), DTrace (Linux, OSX), ETW (Windows)
- [OS Tracing](./os-tracing/README.md) - LTTng (Linux), SystemTap (Linux), DTrace (OSX), ETW (Windows)

- [VM Tracing](./vm-tracing/README.md) - Tracing native to JS VMs, such as V8's TRACE_EVENT.

Expand Down
16 changes: 9 additions & 7 deletions tracing/os-tracing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,24 @@

* [DTrace](http://dtrace.org/)
Available on IllumOS, Solaris, Mac
The [DTrace blog](http://dtrace.org/blogs/blog/category/node-js/) has some articles on using DTrace with Node.js

- The [DTrace blog](http://dtrace.org/blogs/blog/category/node-js/) has some articles on using DTrace with Node.js

* [LTTng](http://lttng.org/)
Linux only.
Some info on using LTTng with Node.js are available in the presentations
[Tracing Node on Linux with LTTNG](http://nearform.github.io/tracing-node-lttng-nodejsdublin/)

- [Tracing Node on Linux with LTTNG](http://nearform.github.io/tracing-node-lttng-nodejsdublin/)
- [thekemkid/magic-tracing](https://github.com/thekemkid/magic-tracing) is an example of a Node.js application which implements LTTng tracepoints. A demo is available [here](https://asciicinema.org/a/16785).

* [ETW](https://msdn.microsoft.com/en-us/library/windows/desktop/aa363668.aspx)
Windows only.
Some information was provided by Bill Ticehurst (@billti) in
[issue #10](https://github.com/nodejs/tracing-wg/issues/10#issuecomment-137145822)
about how he integrated ETW into Node.js for Windows

- Some information was provided by Bill Ticehurst (@billti) in [issue #10](https://github.com/nodejs/tracing-wg/issues/10#issuecomment-137145822) about how he integrated ETW into Node.js for Windows

* [Perf](https://perf.wiki.kernel.org/)
Linux only.
Can be enabled with `--perf_basic_prof` v8 run-time flag.

- Can be enabled with `--perf_basic_prof` v8 run-time flag.

* [SystemTap](https://sourceware.org/systemtap/)
Linux only.
Expand Down
2 changes: 1 addition & 1 deletion tracing/vm-tracing/v8-tracing.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ V8: `trace_event.h` macros utilize `v8::Platform::AddTraceEvent` to write traces
Node uses `DefaultPlatform` from `v8:src/libplatform/default-platform.h` which currently simply returns 0.
A simplistic implementation which logs all trace events to stdout illustrates the basics:

```cpp
```
// from v8:src/libplatform/default-platform.cc
// add `#include <iostream>` to includes
Expand Down

0 comments on commit 86cce77

Please sign in to comment.