Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins build status not visible in big PRs #97

Closed
phillipj opened this issue Nov 22, 2016 · 1 comment · Fixed by #153
Closed

Jenkins build status not visible in big PRs #97

phillipj opened this issue Nov 22, 2016 · 1 comment · Fixed by #153
Labels
bug

Comments

@phillipj
Copy link
Member

With nodejs/node#9745 which has 100+ commits, we just found that the bot pushes Jenkins build status to the wrong commit SHA.

Probably because the list of commits fetched in findLatestCommitInPr() is paginated by GitHub, and therefore we'll have to do some pagination tricks to ensure we actually fetch the latest commit of that specific PR, even if it consists of hundreds of commits.
@phillipj phillipj added the bug label Nov 22, 2016
@jbergstroem
Copy link
Member

ugh :/

phillipj added a commit to phillipj/github-bot that referenced this issue Oct 31, 2017
@phillipj
jenkins: paginate PR commits to find the latest commit
70818f2 
When pushing Jenkins status to a PR, we need to reference the commit
SHA the inline GitHub PR status relates to.

These changes fixes a bug when handling enormous PRs with more than
100 commits, where we have to paginate to commits results for that PR
to find the last commit SHA.

Fixes nodejs#97
@phillipj phillipj mentioned this issue Oct 31, 2017
Merged
phillipj added a commit that referenced this issue Nov 2, 2017
@phillipj
jenkins: paginate PR commits to find the latest commit (#153)
f701303 
When pushing Jenkins status to a PR, we need to reference the commit
SHA the inline GitHub PR status relates to.

These changes fixes a bug when handling enormous PRs with more than
100 commits, where we have to paginate to commits results for that PR
to find the last commit SHA.

Fixes #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jenkins: paginate PR commits to find the latest commit phillipj/github-bot
2 participants
@jbergstroem @phillipj