Make tests work on all Node versions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasongin
commented
May 20, 2017
•
jasongin
commented
- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to test: Make N-API weak-ref GC tests asynchronous node#13121
- In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically
- Add missing entry for object tests in index.js.
- Remove check for writable attribute on accessor property descriptors; it should not be there according to the JS spec.
- Remove the explicit dependency on node-gyp in package.json. (NPM carries its own copy of node-gyp.)
jasongin
force-pushed
the
async-tests
branch
2 times, most recently
from
debda2e to
3bb8676
Compare
addaleax
approved these changes
May 21, 2017
Merged
- Make GC tests (arraybuffer, buffer, external) async, to account for different GC behavior with different versions of V8 and ChakraCore, similar to nodejs/node#13121 - In test/index.js, use the --napi-modules and --expose-gc command-line flags automatically. - Add missing entry for object tests in index.js. - Remove check for writable attribute on accessor property descriptors; it should not be there according to the JS spec. - Remove the explicit dependency on node-gyp in package.json. (NPM carries its own copy of node-gyp.)
Improper rethrow of an Error caught by reference caused a double napi_ref delete, which failed in release builds of Node-ChakraCore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.