This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 339
Wire up resourceNameToUrl
support in inspector
#598
Comments
kfarnung
added a commit
that referenced
this issue
Sep 17, 2018
The inspector tests were broken by a recent upstream PR. Until the support is implemented it's best to skip them. Refs: nodejs/node#22251 Refs: #598
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 19, 2018
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. Fixes: nodejs#598 Refs: nodejs@3f6ef13
4 tasks
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 19, 2018
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. Fixes: nodejs#598 Refs: nodejs/node#22251 Refs: nodejs@3f6ef13
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 19, 2018
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601 Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 19, 2018
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601 Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 19, 2018
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601 Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 20, 2018
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601 Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
With the landing of nodejs/node#22251, the output for the script URL has changed and the tests are now failing. I'm going to skip them for now and re-enable them once the support has been added.
The text was updated successfully, but these errors were encountered: