Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull latest commits from node core #43

Merged
merged 24 commits into from
Feb 2, 2023
Merged

Pull latest commits from node core #43

merged 24 commits into from
Feb 2, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Feb 2, 2023

this is still WIP, going to proceed later

@MoLow
feat: verbous error when entire test tree is canceled
012acb0 
PR-URL: nodejs/node#44060
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 8cf33850bea691d8c53b2d4175c959c8549aa76c)
@MoLow MoLow force-pushed the pull-latest-changes branch 3 times, most recently from 259eb1f to e409b25 Compare February 2, 2023 09:23
MoLow added 3 commits February 2, 2023 11:36
@MoLow
feat: support programmatically running --test
d885ee2 
PR-URL: nodejs/node#44241
Fixes: nodejs/node#44023
Fixes: nodejs/node#43675
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 59527de13d39327eb3dfa8dedc92241eb40066d5)
@MoLow
fix: fix duration_ms to be milliseconds
27241c3 
PR-URL: nodejs/node#44450
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
(cherry picked from commit 6ee1f3444f8c1cf005153f936ffc74221d55658b)
@MoLow
feat: support using --inspect with --test
6755536 
PR-URL: nodejs/node#44520
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit a165193c5c8e4bcfbd12b2c3f6e55a81a251c258)
@MoLow MoLow force-pushed the pull-latest-changes branch from e409b25 to ce33670 Compare February 2, 2023 09:43
MoLow and others added 8 commits February 2, 2023 12:11
@MoLow
fix: include stack of uncaught exceptions
c50f844 
PR-URL: nodejs/node#44614
Fixes: nodejs/node#44611
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit cb7e0c59df10a42cd6930ca7f99d3acee1ce7627)
@MoLow
test: fix test-runner-inspect
1950b38 
PR-URL: nodejs/node#44620
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 9825a7e01d35b9d49ebb58efed2c316012c19db6)
@cjihrig @MoLow
feat: add --test-name-pattern CLI flag
c5fd64c 
This commit adds support for running tests that match a
regular expression.

Fixes: nodejs/node#42984
(cherry picked from commit 87170c3f9271da947a7b33d0696ec4cf8aab6eb6)
@bengl @MoLow
feat: add extra fields in AssertionError YAML
46dce07 
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs/node#44952
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
(cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)
@cjihrig @MoLow
fix: call {before,after}Each() on suites
0bfdb77 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
@MoLow
fix: report tap subtest in order
08269c5 
PR-URL: nodejs/node#45220
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 3e57891ee2fde0971e18fc383c25acf8f90def05)
@MrJithil @MoLow
fix: fix afterEach not running on test failures
f2815af 
PR-URL: nodejs/node#45204
Fixes: nodejs/node#45192
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
(cherry picked from commit 3759935ee29d8042d917d3ceaa768521c14413ff)
@fossamagna @MoLow
fix: avoid swallowing of asynchronously thrown errors
cff397a 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
@MoLow MoLow force-pushed the pull-latest-changes branch from ce33670 to cff397a Compare February 2, 2023 10:13
@cjihrig @MoLow
feat: support function mocking
2e499ee 
This commit allows tests in the test runner to mock functions
and methods.

PR-URL: nodejs/node#45326
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
(cherry picked from commit 7c6682957b3c5f86d0616cebc0ad09cc2a1fd50d)
@MoLow MoLow force-pushed the pull-latest-changes branch from 808862b to ddbce53 Compare February 2, 2023 12:24
manekinekko and others added 2 commits February 2, 2023 15:07
@manekinekko @MoLow
feat: add initial TAP parser
5f8ce61 
Work in progress

PR-URL: nodejs/node#43525
Refs: nodejs/node#43344
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
(cherry picked from commit f8ce9117b19702487eb600493d941f7876e00e01)
@cjihrig @MoLow
fix: remove stdout and stderr from error
5ba2500 
The CLI test runner parses the TAP output from child processes
now and displays it. This commit removes a previous workaround
for displaying child process stdout and stderr when tests
failures occurred.

PR-URL: nodejs/node#45592
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
(cherry picked from commit fec0fbc333c58e6ebbd2322f5120830fda880eb0)
@MoLow MoLow force-pushed the pull-latest-changes branch from ddbce53 to 5ba2500 Compare February 2, 2023 13:07
fossamagna and others added 8 commits February 2, 2023 15:43
@fossamagna @MoLow
feat: add getter and setter to MockTracker
b942f93 
This commit allows tests in test runner to use the
`getter` and `setter` methods as "syntax sugar" for
`MockTracker.method` with the `options.getter` or
`options.setter` set to true in the options.

Refs: nodejs/node#45326 (comment)
PR-URL: nodejs/node#45506
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit afed1afa55962211b6b56c2068d520b4d8a08888)
@cjihrig @MoLow
fix: don't use a symbol for runHook()
b3b384e 
This is not exposed to userland, so there is no need to put it
behind a symbol.

PR-URL: nodejs/node#45792
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
(cherry picked from commit 8302b0add01758713246117d3d0533cd212f160d)
@cjihrig @MoLow
feat: add t.after() hook
71b659e 
This commit adds an after() hook to the TestContext class. This
hook can be used to clean up after a test finishes.

PR-URL: nodejs/node#45792
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
(cherry picked from commit 215c5317d4837287fddb2e3b97872babd53183ac)
@pulkit-30 @MoLow
test: fix invalid output TAP if there newline in test name
c0854ac 
PR-URL: nodejs/node#45742
Fixes: nodejs/node#45396
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
(cherry picked from commit 22dc987fde29734c5bcbb7c33da20d184ff61627)
@aduh95 @MoLow
chore: refactor tap_parser to use more primordials
9b49978 
PR-URL: nodejs/node#45745
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
(cherry picked from commit 7a42a206ac37d95060640b4812aaef32535937e1)
@aduh95 @MoLow
chore: refactor tap_lexer to use more primordials
4e778bc 
PR-URL: nodejs/node#45744
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
(cherry picked from commit 2483da743cbb48f31c6b3f8cb186d89f31d73611)
@MoLow
feat: parse yaml
d1343a7 
PR-URL: nodejs/node#45815
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 232efb06fe8787e9573e298ce7ac293ad23b7684)
@cjihrig @MoLow
fix: run t.after() if test body throws
c80e426 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.

PR-URL: nodejs/node#45870
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
(cherry picked from commit 385d595a4f1d887f6d4221e6071571132498d57c)
@ErickWendel @MoLow
test: fix mock.method to support class instances
9fa496b 
It fixes a problem when trying to spy a method
from a class instance or static functions
on a class instance

PR-URL: nodejs/node#45608
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
(cherry picked from commit 929aada39d0f418193ca03cc360ced8c5b4ce553)
@MoLow MoLow marked this pull request as ready for review February 2, 2023 13:48
@MoLow MoLow requested a review from aduh95 February 2, 2023 13:48
aduh95
aduh95 approved these changes Feb 2, 2023
View reviewed changes
README.md
Comment on lines +444 to +448
If truthy, it would run (number of cpu cores - 1)
files in parallel.
If falsy, it would only run one file at a time.
If unspecified, subtests inherit this value from their parent.
**Default:** `true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being amended in nodejs/node#46457, it'd be nice to have the corrected version (assuming it indeed needs to be corrected, which I think it does) – doesn't have to block this PR from landing, but maybe we shouldn't deploy the release immediately.

@MoLow
Copy link
Member Author

MoLow commented Feb 2, 2023

I will merge this and will create another PR with some more unmerged features.
we can release after that

@MoLow MoLow merged commit 2cfde23 into nodejs:main Feb 2, 2023
@MoLow MoLow deleted the pull-latest-changes branch February 2, 2023 18:30
@MoLow MoLow restored the pull-latest-changes branch February 6, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MoLow @aduh95 @cjihrig @bengl @MrJithil @fossamagna @manekinekko @pulkit-30 @ErickWendel