git-node: Clarify that the wait time is a *minimum* not a maximum.

nodejs · Oct 5, 2018 · 16b5776 · 16b5776
1 parent 38fbb3e
commit 16b5776
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/pr_checker.js b/lib/pr_checker.js
@@ -185,7 +185,7 @@ class PRChecker {
       const dateStr = new Date(pr.createdAt).toDateString();
       const type = wait.isWeekend ? 'weekend' : 'weekday';
       cli.info(`This PR was created on ${dateStr} (${type} in UTC)`);
-      cli.warn(`${wait.timeLeft} hours left to land`);
+      cli.warn(`Wait at least ${wait.timeLeft} more hours before landing`);
       return false;
     }
 

diff --git a/test/unit/pr_checker.test.js b/test/unit/pr_checker.test.js
@@ -169,7 +169,7 @@ describe('PRChecker', () => {
       const cli = new TestCLI();
 
       const expectedLogs = {
-        warn: [['49 hours left to land']],
+        warn: [['Wait at least 49 more hours before landing']],
         info: [['This PR was created on Sat Oct 28 2017 (weekend in UTC)']]
       };
 
@@ -201,7 +201,7 @@ describe('PRChecker', () => {
       const cli = new TestCLI();
 
       const expectedLogs = {
-        warn: [['22 hours left to land']],
+        warn: [['Wait at least 22 more hours before landing']],
         info: [['This PR was created on Tue Oct 31 2017 (weekday in UTC)']]
       };