feat(git-node): add release promotion step #835

aduh95 · 2024-07-22T12:59:26Z

You can try it with git node release -S --promote https://github.com/nodejs/node/pull/53945.

Supersedes #402

/cc @nodejs/releasers

Co-Authored-By: Michaël Zasso <[email protected]>

targos · 2024-10-03T20:19:08Z

It is v20.x-staging, which is normal from my pov. I work on a v20.x release in my v20.x workspace

aduh95 · 2024-10-04T12:37:08Z

It is v20.x-staging, which is normal from my pov

Does it need to be v20.x-staging for something else? Landing backport PR maybe? Asking because I'm wondering if we should rename it to defaultBranch to avoid the confusion – or if I choose just make an API call to get the name of the default branch (and assume there's a local branch with that name)

targos · 2024-10-04T12:47:38Z

I believe it's for backport PRs, but I'm not sure.

aduh95 · 2024-10-12T08:52:18Z

I've confirmed that to land a (backport or not) PR to a staging branch, NCU request you to set a different branch in your config. I've updated the promotion script to make an API call to get the name of the default branch instead of relying on the config.
I've also added a fallback when the version tag already exists to not crash if it points to the right commit and is correctly signed.

aduh95 · 2024-11-13T10:55:06Z

I've tried it with the v18.20.5 release, and did not get any blocker. I'm tempted to land it, we might still want to iterate on it but I think it's at a point where we can rely on it. @nodejs/releasers, wdyt?

targos · 2024-11-13T10:56:24Z

LGTM

Refs: nodejs/node-core-utils#835

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Refs: nodejs/node-core-utils#835 PR-URL: nodejs#55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

codebytere and others added 30 commits May 20, 2020 11:45

git-node: add release promotion step

9ee6605

Move newVersion to named arg

15c4cb0

Split out promotion verification steps

0ec3327

Fix verification spinners

a1c3ef1

Verify ncurc is set up

61dbeb7

Properly trim getCommitSha result

ea29f87

Co-Authored-By: Michaël Zasso <[email protected]>

Address some feedback

c0db1ce

Ensure synced with upstream/master

7d23d70

fix: run release script asynchronously

692c6b7

Run secureTagRelease() asynchronously

c1ab158

Run cherry-pick asynchronously

ddfe6ef

Remove unneccessary quotes

3377b44

Merge branch 'main' of https://github.com/nodejs/node-core-utils

88b99f3

nits

a08566d

esm

0229ccf

some refactor + more checks

ba23781

fixup! Merge branch 'main' of https://github.com/nodejs/node-core-utils

8ef8c41

throw on error to get non-zero exit code

8d02a41

lint

15c0335

validate CHANGELOG heading

ce72380

add support for PR URL

519388c

check if local HEAD is in sync with release proposal

a1b1974

Use existing tryResetBranch instead of custom git command

6db9959

auto fix node_version conflicts

3cc80b1

add --dryRun mode to simplify testing

04b4d4d

fix conflicts making the process crash

70294cf

fix bug when checking modified files

549ac8e

do not hard code default branch name

4bd64c9

fix type

1104f09

add --gpgSign/-S option

5b91899

aduh95 added 4 commits October 11, 2024 11:51

fetch default branch name from GitHub API

a9512d0

add spinner when fetching the proposal

37ffe70

fixup! fetch default branch name from GitHub API

c3fb51e

allow reusing existing tag as long as it points to the correct commit

55e4a79

aduh95 added 2 commits November 6, 2024 00:03

Merge branch 'main' into git-node-release-promote

e78b1c7

fix alphabetical order

94e38df

targos approved these changes Nov 13, 2024

View reviewed changes

marco-ippolito approved these changes Nov 13, 2024

View reviewed changes

RafaelGSS approved these changes Nov 13, 2024

View reviewed changes

RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Nov 13, 2024

doc: include git node release --promote to steps

a2d8afc

Refs: nodejs/node-core-utils#835

RafaelGSS mentioned this pull request Nov 13, 2024

doc: include git node release --promote to steps nodejs/node#55835

Merged

aduh95 merged commit dfa9c92 into nodejs:main Nov 13, 2024
10 of 11 checks passed

aduh95 deleted the git-node-release-promote branch November 13, 2024 14:07

nodejs-github-bot mentioned this pull request Nov 13, 2024

chore(main): release 5.7.0 #868

Merged

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024

doc: include git node release --promote to steps

87cb587

Refs: nodejs/node-core-utils#835 PR-URL: nodejs#55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

aduh95 pushed a commit to nodejs/node that referenced this pull request Nov 26, 2024

doc: include git node release --promote to steps

219f5f2

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

aduh95 pushed a commit to nodejs/node that referenced this pull request Dec 10, 2024

doc: include git node release --promote to steps

478fe36

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

ruyadorno pushed a commit to nodejs/node that referenced this pull request Jan 5, 2025

doc: include git node release --promote to steps

3e6b3a9

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

marco-ippolito pushed a commit to nodejs/node that referenced this pull request Jan 22, 2025

doc: include git node release --promote to steps

e52cedd

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

marco-ippolito pushed a commit to nodejs/node that referenced this pull request Jan 22, 2025

doc: include git node release --promote to steps

b36f966

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

marco-ippolito pushed a commit to nodejs/node that referenced this pull request Jan 22, 2025

doc: include git node release --promote to steps

0e0d61d

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

marco-ippolito pushed a commit to nodejs/node that referenced this pull request Jan 24, 2025

doc: include git node release --promote to steps

61de8f9

Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(git-node): add release promotion step #835

feat(git-node): add release promotion step #835

aduh95 commented Jul 22, 2024 •

edited

Loading

targos commented Oct 3, 2024

aduh95 commented Oct 4, 2024

targos commented Oct 4, 2024

aduh95 commented Oct 12, 2024 •

edited

Loading

aduh95 commented Nov 13, 2024

targos commented Nov 13, 2024

feat(git-node): add release promotion step #835

feat(git-node): add release promotion step #835

Conversation

aduh95 commented Jul 22, 2024 • edited Loading

targos commented Oct 3, 2024

aduh95 commented Oct 4, 2024

targos commented Oct 4, 2024

aduh95 commented Oct 12, 2024 • edited Loading

aduh95 commented Nov 13, 2024

targos commented Nov 13, 2024

aduh95 commented Jul 22, 2024 •

edited

Loading

aduh95 commented Oct 12, 2024 •

edited

Loading